Landings for Stack Containing D341636

Successfully landed

Landing requested on , by pchevrel@mozilla.com.

Landing Job: 118428

Revisions: D341636 diff 1436258

Last update:

Result: 4da033154c0587c749b33b6c5bbd7c54460aa358 on firefox-beta@beta (git)

Links: Treeherder

Uplifts

D341636 is approved for uplift Bug 2088486 · Assessment #5978

Assessment #5978

, by dholbert@mozilla.com. Requested for uplift from D341481

User impact: The reason for urgency is that this is a new high-volume crash, with the volume largely coming from a prominent website, ChatGPT, which seems to have had a change that made it susceptible to... Risk: Low

Show all answers
User impact if declined/Reason for urgency The reason for urgency is that this is a new high-volume crash, with the volume largely coming from a prominent website, ChatGPT, which seems to have had a change that made it susceptible to trigger this crash)
Code covered by automated testing? Yes
Fix verified in Nightly? Yes
Needs manual QE testing? Yes
Steps to reproduce for manual QE testing Load attached testcase 1, and see if it triggers the crashed-tab UI.
Risk associated with taking this patch Low
Explanation of risk level It makes us snapshot an array and iterate over that snapshot, in case the original array is changed out from under us. The snapshot has its own `RefPtr` references, so it will ensure that the iterated objects are kept alive, even if the original array gets modified.
String changes made/needed? None.
Is Android affected? Yes
Train Stack tip Status
firefox-beta D341636 Created by Lando View job
firefox-esr153 D341637 Created by Lando View job
1 other assessment for bug 2088486
#5979 The reason for urgency is that this is a new high-volume crash, with the volume largely coming from a prominent... linked to D341638

Stack containing revision D341636

Land Bug Status Revision Reviewers
2088486
Blocked
Revision is closed.
Closed
D341636: Bug 2088486 - Make Selection::Repaint do its iteration over a copy of the ranges instead of the main array.
  • @release-managers accepted a prior diff
  • @pascalc accepted a prior diff