Landings for Stack Containing D341481
Landing requested on , by dholbert@mozilla.com.
Landing Job: 117655
Revisions: D341481 diff 1435557
Last update:
Result: e8cabcfefea7be14e3b0dd8bdebc5b93283ddd51 on firefox-autoland@autoland (git)
Links: Treeherder
Uplifts
Uplift assessments for bug 2088486
, by dholbert@mozilla.com. Requested for uplift from D341481
User impact: The reason for urgency is that this is a new high-volume crash, with the volume largely coming from a prominent website, ChatGPT, which seems to have had a change that made it susceptible to... Risk: Low
Show all answers
| User impact if declined/Reason for urgency | The reason for urgency is that this is a new high-volume crash, with the volume largely coming from a prominent website, ChatGPT, which seems to have had a change that made it susceptible to trigger this crash) |
|---|---|
| Code covered by automated testing? | Yes |
| Fix verified in Nightly? | Yes |
| Needs manual QE testing? | Yes |
| Steps to reproduce for manual QE testing | Load attached testcase 1, and see if it triggers the crashed-tab UI. |
| Risk associated with taking this patch | Low |
| Explanation of risk level | It makes us snapshot an array and iterate over that snapshot, in case the original array is changed out from under us. The snapshot has its own `RefPtr` references, so it will ensure that the iterated objects are kept alive, even if the original array gets modified. |
| String changes made/needed? | None. |
| Is Android affected? | Yes |
| Train | Stack tip | Status | |
|---|---|---|---|
| firefox-beta | D341636 | Created by Lando | View job |
| firefox-esr153 | D341637 | Created by Lando | View job |
, by dholbert@mozilla.com. Requested for uplift from D341481
User impact: The reason for urgency is that this is a new high-volume crash, with the volume largely coming from a prominent website, ChatGPT, which seems to have had a change that made it susceptible to... Risk: Low
Show all answers
| User impact if declined/Reason for urgency | The reason for urgency is that this is a new high-volume crash, with the volume largely coming from a prominent website, ChatGPT, which seems to have had a change that made it susceptible to trigger this crash) |
|---|---|
| Code covered by automated testing? | Yes |
| Fix verified in Nightly? | Yes |
| Needs manual QE testing? | Yes |
| Steps to reproduce for manual QE testing | Load attached testcase 1, and see if it triggers the crashed-tab UI. |
| Risk associated with taking this patch | Low |
| Explanation of risk level | It makes us snapshot an array and iterate over that snapshot, in case the original array is changed out from under us. The snapshot has its own `RefPtr` references, so it will ensure that the iterated objects are kept alive, even if the original array gets modified. |
| String changes made/needed? | None |
| Is Android affected? | Yes |
| Train | Stack tip | Status | |
|---|---|---|---|
| firefox-release | D341638 | Created by Lando | View job |
Stack containing revision D341481
| Land | Bug | Status | Revision | Reviewers | |
|---|---|---|---|---|---|
| 2088486 |
Blocked
Revision is closed.
Closed |
D341481: Bug 2088486 - Make Selection::Repaint do its iteration over a copy of the ranges instead of the main array. r?jjaschke
|
|
Request submitted
Your request for review by the sec-approval team has been submitted.