ui: Only show TreeHerder link if enabled (bug 2004162) #788 (lando@main)
| Warnings |
|
|---|---|
| Blockers |
|
| Branches | bug2004162/treeherder-link-repo -> main |
| Repo | lando@main (git) (git://github.com/mozilla-conduit/lando.git) |
| Author | shtrom |
| State | closed |
| Title | ui: Only show TreeHerder link if enabled (bug 2004162) |
| Description | This commit introduces a new `Repo.treeherder_name` field. If this field is not empty, Treeherder links are shown. In addition, the `repo` QueryString parameter is added to those links, to match the `treeherder_name`. This allows lando to point to results for commits which are not on `autoland` (the Treeherder default). Two data migration steps are included in this change for pre-existing repos: * use HgMO url to find the treeherder name; * use the git default_branch for `firefox-` Git repos. --- * Repo: add treeherder_name field (bug 2004162) * jinja2: update type hints (Bug 1986844) * jinja2: use Repo.treeherder_name in treeherder_link (bug 2004162) * ui: Only show TreeHerder link if enabled (bug 2004162) |
Landings
Successfully landed
Landing requested on , by omehani@mozilla.com.
Landing Job: 24317
Failed to land
Landing requested on , by omehani@mozilla.com.
Landing Job: 24316
Last update:
Raw error output: Aborting, could not apply patch buffer for None. Error running git command; sanitised_command=['git', 'apply', '--reject', '/tmp/tmp6f1c4l7v.patch'], path='/files/repos/lando', Checking patch src/lando/main/migrations/0042_repo_treeherder_name.py... Checking patch src/lando/main/models/repo.py... Checking patch src/lando/jinja.py... Checking patch src/lando/jinja.py... Checking patch src/lando/ui/jinja2/partials/job.html... Checking patch src/lando/ui/tests/test_ui.py... Checking patch src/lando/ui/jinja2/partials/job.html... Checking patch src/lando/main/migrations/0042_repo_treeherder_name.py... Checking patch src/lando/main/migrations/0042_repo_treeherder_name.py => src/lando/main/migrations/0043_repo_treeherder_name.py... error: src/lando/main/migrations/0042_repo_treeherder_name.py: No such file or directory Checking patch src/lando/ui/jinja2/stack/pull_request.html... Checking patch src/lando/jinja.py... Applied patch src/lando/main/migrations/0042_repo_treeherder_name.py cleanly. Applied patch src/lando/main/models/repo.py cleanly. Applied patch src/lando/jinja.py cleanly. Applied patch src/lando/jinja.py cleanly. Applied patch src/lando/ui/jinja2/partials/job.html cleanly. Applied patch src/lando/ui/tests/test_ui.py cleanly. Applied patch src/lando/ui/jinja2/partials/job.html cleanly. Applied patch src/lando/main/migrations/0042_repo_treeherder_name.py cleanly. Applied patch src/lando/ui/jinja2/stack/pull_request.html cleanly. Applied patch src/lando/jinja.py cleanly.