testing: monkeypatch over `settings.REPO_ROOT` instead of over-writing (Bug 2031725) #1090 (lando@main)
| Warnings |
|
|---|---|
| Blockers |
|
| Branches | intermittent-test -> main |
| Repo | lando@main (git) (git://github.com/cgsheeh/lando.git) |
| Author | cgsheeh |
| State | closed |
| Commit Title | testing: monkeypatch over `settings.REPO_ROOT` instead of over-writing (Bug 2031725) |
| Commit Body | We previously overwrote the `settings.REPO_ROOT` variable in `test__models__Repo__pulse_routing_key_validator`, which would then cause failures in `test__models__Repo__system_path_validator`, since the variable we used at test collection time. Instead, `monkeypatch` over the variable in the Pulse test to avoid polluting other tests. Also create the path variable inside the test, instead of at module collection time, to avoid regressing this issue in the future. |
Landings
Successfully landed
Landing requested on , by cosheehan@mozilla.com.
Landing Job: 36348