Bug 2011184 - check fragment is added before finding nav controller. #56 (firefox-autoland@autoland)
| Warnings |
|
|---|---|
| Blockers |
|
| Last try job |
|
| Branches | illegalstate-qrcode-search-crash -> autoland |
| Repo | firefox-autoland@autoland (git) (git://github.com/pollym/firefox.git) |
| Author | pollym |
| State | closed |
| Commit Title | Bug 2011184 - check fragment is added before finding nav controller. |
| Commit Body | We are seeing `IllegalStateException`s in the play store from calling `findNavController` when the fragment is not associated with a transaction (the parentFragmentManager is null) `isAdded()` is the recommended way to find out if this fragment is attached to an activity and `findNavController()` is safe to call NB this fix is based on static analysis only - plan is to keep an eye on the crash logs after it lands to confirm it works. [running a try here](https://treeherder.mozilla.org/jobs?repo=try&revision=f74abab716cd9b4f9af2b1742294c4712f80644c) but it seems to have included every commit since dinosaurs roamed the earth, not sure what happened there |
Landings
Successfully landed
Landing requested on , by pmceldowney@mozilla.com.
Landing Job: 27171
Last update:
Result: c0d96cf6aa8c4a8dfb16a755fc2f95b86e243473 on firefox-autoland@autoland (git)
Links: Treeherder