Bug 1965752 - Regenerate Nimbus code when a manifest's included or imported FML file changes #431 (firefox-autoland@autoland)
|
|
|
| Warnings |
|
| Blockers |
|
| Branches | bug1965752 -> autoland |
| Repo | firefox-autoland@autoland (git) (git://github.com/corentinbect/firefox.git) |
| Author | corentinbect |
| State | closed |
| Commit Title |
Bug 1965752 - Regenerate Nimbus code when a manifest's included or imported FML file changes |
| Commit Body |
The `nimbusFeatures` task only declared the top level manifest as an input, but the manifest can load other FML files transitively using `includes` or `import`. Editing one of these dependencies such as `onboarding.fml.yaml` didn't regenerate Nimbus code, so `FxNimbus` stayed stale until the generated file was manually deleted. This adds `nimbus.manifestDependencies` property, which is to a new `@InputFiles` property in `NimbusFeaturesTask`. Fenix now lists the imported and included FML files so `FxNimbus` is regenerated when they change. Two other approaches were considered: - Using a file tree with every `*.fml.yaml`, but it would also get unrelated files that match the pattern. - Parsing the manifest's dependencies recursively using a YAML dependency. Listing the files manually is the simplest option, and it gives explicit control over the files that trigger the regeneration. |
Landings
Landing requested on , by cbect@mozilla.com.
Landing Job: 115688
Last update:
Result: dea285e49297cd335f0b84c9ccd1c4b5ea18686e on firefox-autoland@autoland (git)
Links: Treeherder