Bug 2088788 - Add haptic feedback to onboarding buttons, links, toggl… #429 (firefox-autoland@autoland)
|
|
|
| Warnings |
|
| Blockers |
|
| Branches | onboarding-haptic-feedback -> autoland |
| Repo | firefox-autoland@autoland (git) (git://github.com/t-p-white/firefox.git) |
| Author | t-p-white |
| State | closed |
| Commit Title |
Bug 2088788 - Add haptic feedback to onboarding buttons, links, toggl… |
| Commit Body |
Gated behind `FeatureFlags.onboardingHapticsEnabled` (Nightly and debug only) so it can be tried on-device before deciding whether to ship it. Swipes only play when the pager settles after a user drag, so advancing with a button does not buzz twice. **Reviewer notes**: To test in debug, enable the`FeatureFlag` ` val onboardingFeatureEnabled = Config.channel.isDebug` and have fresh install. **Implementation notes**: the wrapping helpers (`hapticOnClick`, `hapticOnLinkClick`, `hapticOnCheckedChange`) live in the onboarding package for now. They are the first tap haptics in the tree (existing usages are all long-press, or Confirm on pull-to-refresh), so we should move to android-components compose/base alongside `LongPressIconButton` if the we move this change into production. |
Landings
Landing requested on , by icedicedcoffee@proton.me.
Landing Job: 114507
Last update:
Result: ea0a0b11be23a45ee1c47cf286cb20a10f1da480 on firefox-autoland@autoland (git)
Links: Treeherder