Bug 2068241 - When Firefox is already installed and onboarded, open a custom tab for the sign-in flow. #415 (firefox-autoland@autoland)
|
|
|
| Warnings |
|
| Blockers |
|
| Branches | 2068241 -> autoland |
| Repo | firefox-autoland@autoland (git) (git://github.com/t-p-white/firefox.git) |
| Author | t-p-white |
| State | closed |
| Commit Title |
Bug 2068241 - When Firefox is already installed and onboarded, open a custom tab for the sign-in flow. |
| Commit Body |
A QR-scanned pairing link (`accounts.firefox.com/pair#channel_id=...`) reaches Firefox through the App Links filter on `IntentReceiverActivity`. Previously, it fell through to the regular tab processor, leaving the FxA page open as a normal tab after sign-in or when abandoned. `IntentReceiverActivity` now records `pairing_link_opened` and opens the link with `createAuthCustomTabIntent`, the same route every sign-in entry point takes into `AuthCustomTabActivity`. That activity finishes on `onAuthenticated` and removes its custom tab whenever it is left, so neither success nor abandonment leaves a tab behind. Pairing links no longer count towards `opened_link`. This mirrors `PairFragment`, which handles the same URL from the in-app QR scanner: - **In-app scanner:** `PairFragment` hands the URL to the native pairing flow and opens the resulting `/pair/supp` OAuth URL in the auth custom tab. - **External scanner:** the `/pair` page itself loads in the auth custom tab, and FxA starts OAuth over the pairing v2 web channel. Both complete through the `fxaccounts:oauth_login` web channel message. The receiver’s transparent theme and the application context both lack the Material `colorSurface` attribute that `createCustomTabIntent` reads, so the intent is built using a `ContextThemeWrapper` with `NormalTheme`. |
Landings
Landing requested on , by icedicedcoffee@proton.me.
Landing Job: 110291
Last update:
Result: 7d5b7309c54720c05434c9c7eb74db54fe69b26d on firefox-autoland@autoland (git)
Links: Treeherder