Bug 2071822 - turn on minification in nightly ui tests, but not resource shrinking #398 (firefox-autoland@autoland)
|
|
|
| Warnings |
|
| Blockers |
|
| Branches | minified-ui-tests-try -> autoland |
| Repo | firefox-autoland@autoland (git) (git://github.com/pollym/firefox.git) |
| Author | pollym |
| State | open |
| Commit Title |
Bug 2071822 - turn on minification in nightly ui tests, but not resource shrinking |
| Commit Body |
Verify that minification doesn't break anything by running the ui tests against a minified nightly build. Reasoning for doing this is: a) our release builds are currently minified, but our ui test builds are not. So nothing currently tests minification doesn't break anything in release. You would really hope r8 minification wouldn't break and trust it to do its thing, as it's very widely used! But this is another step bringing what we ship closer to what we test. b) it's also a step towards turning on obfuscation - we need to have the broader `disable-optimisation` flag switched off to be able to enable the obfuscation part. Resource shrinking breaks everywhere the tests need to look up a string resource that the app doesn't use, because r8 has optimised it away. Similar to the issue with classes and methods; this could be a future extension for the gradle plugin to generate keep rules for, but for now we can get the minified tests running by leaving the resource shrinking part switched off. NB this requires the gradle plugin added in https://github.com/mozilla-firefox/firefox/pull/395 [green try here](https://treeherder.mozilla.org/jobs?repo=try&revision=8d4819ebaa182a829fe1b920ab8eb150172b7210) |