Bug 2071822 - remove duplicate classes from androidTest dir. #388 (firefox-autoland@autoland)
|
|
|
| Warnings |
|
| Blockers |
|
| Branches | fix-duplicate-classes-for-r8 -> autoland |
| Repo | firefox-autoland@autoland (git) (git://github.com/pollym/firefox.git) |
| Author | pollym |
| State | closed |
| Commit Title |
Bug 2071822 - remove duplicate classes from androidTest dir. |
| Commit Body |
These break obfuscation and were not being used any more. `FxaServer` was previously used by `SyncIntegrationTest`, which is not currently run, so if this is ever restored we will have to figure out a minification-friendly way of doing this. (I've chatted to mobile test about this) some more details: - The `androidTest` copies break once the build is minified. R8 rewrites the app's version, so the test copy no longer matches it. - The test `AppRequestInterceptor` had drifted from the real one. It was missing about:home handling, the story UTM interceptor, interceptsAppInitiatedRequests and the content-URI telemetry. - also, the test version of `AppRequestInterceptor` had different behaviour to the app one. The app one overrode `interceptsAppInitiatedRequests` to set it to true and the test one didn't, so it defaulted to false. This means that using the app one, you get a "Open this link in xxx app?" dialog which the tests didn't previously expect. <img width="304" height="550" alt="example of the app links dialog" src="https://github.com/user-attachments/assets/cac27662-9c72-4e37-9ffe-13916cf9a1b5" /> I've fixed this by dismissing the dialog in `MainMenuTest`. [try is running here](https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=104609) |
Landings
Landing requested on , by pmceldowney@mozilla.com.
Landing Job: 104681
Last update:
Result: 92f9de0a78505d37884e9d7696a4368e4fd54f03 on firefox-autoland@autoland (git)
Links: Treeherder