Landings for Stack Containing D342568

Successfully landed

Landing requested on , by pbone@mozilla.com.

Landing Job: 119733

Revisions: D342568 diff 1439796

Last update:

Result: f6a91897b6b1f39aa2593e0dfa656bfdb04acfe3 on firefox-autoland@autoland (git)

Links: Treeherder

Uplifts

Uplift assessments for bug 2070617

Assessment #6044

, by pbone@mozilla.com. Requested for uplift from D342568

User impact: We've noticed an increased number of OOM crashes including https://bugzilla.mozilla.org/show_bug.cgi?id=2084968#c23 which has become a topcrash. There may be multiple causes but it's become clear... Risk: Low

Show all answers
User impact if declined/Reason for urgency We've noticed an increased number of OOM crashes including https://bugzilla.mozilla.org/show_bug.cgi?id=2084968#c23 which has become a topcrash. There may be multiple causes but it's become clear that a performance optimization made in Bug 2055507 (already in Firefox 157) is one of them, since it allows the spare chunks list on a mozjemalloc arena to grow unbounded. A different arena (in the same or a different process) may fail to allocate memory if chunks are held in the spare chunks lists. This uplift request is a simple change that restores the earlier limit of one spare chunk per arena.
Code covered by automated testing? Yes
Fix verified in Nightly? Yes
Needs manual QE testing? No
Steps to reproduce for manual QE testing —
Risk associated with taking this patch Low
Explanation of risk level Because the patch is small and restores the earlier behaviour I am confident that it won't create other problems. However it will "undo" a performance optimisation (about 0.5 - 1%), we are working on a proper fix for that to land in the future. Meanwhile this mitigation means that Firefox will be more stable even if very slightly slower.
String changes made/needed? None
Is Android affected? Yes
Train Stack tip Status
firefox-beta D343014 Created by Lando View job

Stack containing revision D342568

Land Bug Status Revision Reviewers
2070617
Blocked
Revision is closed.
Closed
D342568: Bug 2070617 - Synchronously remove excess chunks r=glandium,jstutte
  • @jstutte accepted a prior diff