Landings for Stack Containing D339740

Successfully landed

Landing requested on , by dmeehan@mozilla.com.

Landing Job: 119430

Revisions: D339740 diff 1428609

Last update:

Result: 4d5f09b192dcd716c6becdfb6d31acc631e6a163 on firefox-release@release (git)

Links: Treeherder

Uplifts

D339740 is approved for uplift Bug 2086786 · Assessment #5897

Assessment #5897

, by bballo@mozilla.com. Requested for uplift from D339005

User impact: When touchpad scrolling on a page that intends to handle all scroll gestures itself by using an active wheel listener that calls preventDefault() on every event, occasionally an event can... Risk: Medium

Show all answers
User impact if declined/Reason for urgency When touchpad scrolling on a page that intends to handle all scroll gestures itself by using an active wheel listener that calls preventDefault() on every event, occasionally an event can incorrectly get through to default handling (scrolling) by the browser.
Code covered by automated testing? Yes
Fix verified in Nightly? Yes
Needs manual QE testing? No
Steps to reproduce for manual QE testing —
Risk associated with taking this patch Medium
Explanation of risk level This area of the code is tricky and historically prone to regressions. However, the risk of a serious regression is low due to having accumulated significant test coverage (and it would be noticed quickly on the nightly channel).
String changes made/needed? none
Is Android affected? No
Train Stack tip Status
firefox-release — Failed View job
Raw error output:
Aborting, could not apply patch buffer for 339005.
Error running git command; sanitised_command=['git', 'cherry-pick', '84da89381479f364481410e2b8d41022840e945a'], path='/files/repos/firefox-release', error: could not apply 84da89381479... Bug 2086786 - Guard against a zero-delta pan-end event causing APZ to let a (momentum) scroll through when content is preventDefault-ing wheel events. r=hiro
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

To manually resolve conflicts and submit your uplift:

git fetch origin
git switch -c uplift-firefox-release-D339005 origin/release
git cherry-pick 84da89381479f364481410e2b8d41022840e945a
moz-phab uplift --train firefox-release --assessment-id 5897

Run these commands from your Firefox checkout. Resolve any merge conflicts during the patch application process, then submit with moz-phab uplift.

Note: These commands assume your official Firefox remote is named origin. If you use a different remote name, adjust the commands accordingly.

D339740 Submitted with moz-phab

Stack containing revision D339740

Land Bug Status Revision Reviewers
2086786
Blocked
Revision is closed.
Closed
D339740: Bug 2086786 - Guard against a zero-delta pan-end event causing APZ to let a (momentum) scroll through when content is preventDefault-ing wheel events.
  • @release-managers accepted a prior diff
  • @dmeehan accepted a prior diff