Landings for Stack Containing D339544

Successfully landed

Landing requested on , by pchevrel@mozilla.com.

Landing Job: 119133

Revisions: D339544 diff 1427955

Last update:

Result: cb33d39f2d934eb018b4ad9920d9ac60d2b77959 on firefox-esr153@esr153 (git)

Links: Treeherder

Uplifts

D339544 is approved for uplift Bug 2083975 · Assessment #5892

Assessment #5892

, by mozilla@kaply.com. Requested for uplift from D336938

User impact: Infobar for TOS and forced update doesn't show in all windows. Regression Risk: Low

Show all answers
User impact if declined/Reason for urgency Infobar for TOS and forced update doesn't show in all windows. Regression
Code covered by automated testing? Yes
Fix verified in Nightly? Yes
Needs manual QE testing? No
Steps to reproduce for manual QE testing —
Risk associated with taking this patch Low
Explanation of risk level Actually makes the code more reliable
String changes made/needed? None
Is Android affected? No
Train Stack tip Status
firefox-esr153 — Failed View job
Raw error output:
Aborting, could not apply patch buffer for 336938.
Error running git command; sanitised_command=['git', 'cherry-pick', '6850376f392e2d7718517930de9f69e619932eb5'], path='/files/repos/firefox-esr153', error: could not apply 6850376f392e... Bug 2083975 - Wait for load before showing a universal infobar in a new window. r=omc-reviewers,mimi
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config advice.mergeConflict false"

To manually resolve conflicts and submit your uplift:

git fetch origin
git switch -c uplift-firefox-esr153-D336938 origin/esr153
git cherry-pick 6850376f392e2d7718517930de9f69e619932eb5
moz-phab uplift --train firefox-esr153 --assessment-id 5892

Run these commands from your Firefox checkout. Resolve any merge conflicts during the patch application process, then submit with moz-phab uplift.

Note: These commands assume your official Firefox remote is named origin. If you use a different remote name, adjust the commands accordingly.

D339544 Submitted with moz-phab

Stack containing revision D339544

Land Bug Status Revision Reviewers
2083975
Blocked
Revision is closed.
Closed
D339544: Bug 2083975 - Wait for load before showing a universal infobar in a new window.
  • @release-managers accepted a prior diff
  • @pascalc accepted a prior diff